There are some attributes such as "good company" that are paramount. But for me it also depends a LOT on what the trip is for. Went out yesterday for the first time with a guy I met. Fished locally for redfish. The weather was tough and we both got skunked. But I had a great time. For that kind of trip its a lot about being on the water with good folks.

But in two weeks I am heading to the Seychelles. I would be flat lying if I said its all about "good company" I am going with a very good friend and fishing buddy so that is covered. But this trip has some built in expectations. To make it a good trip I think these have to be in place:
1. Quality gear and guides
2. Quality fishery with opportunities.

Perhaps the best way to put it is that the outfit has done an adequate job of the things that are in their control. And they do their best to deal with less than optimal things they can't control. Did you get what you paid for?